-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] refactoring user addition to group to graphapi #7360
[tests-only][full-ci] refactoring user addition to group to graphapi #7360
Conversation
83dbfa3
to
77995df
Compare
77995df
to
323225c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, using nonexistent
constantly should do the trick and we don't have to add extra param
655d446
to
5a4c035
Compare
26d7907
to
711dba5
Compare
767a6d1
to
3fff698
Compare
a92f5ff
to
f786a06
Compare
f786a06
to
67b47d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just small change Other LGTM 👍
67b47d4
to
f3286e8
Compare
f3286e8
to
f98197b
Compare
Kudos, SonarCloud Quality Gate passed! |
…7360) * changed user addition to group to graphapi * addressing the review * addressing review regarding nonexistent user * addressing the review * updated expected failures file * changing code to make it pass in reva edge * addressing review * addressing review
…7360) * changed user addition to group to graphapi * addressing the review * addressing review regarding nonexistent user * addressing the review * updated expected failures file * changing code to make it pass in reva edge * addressing review * addressing review
… group to graphapi (#7545) * backporting the PR * [tests-only][full-ci] refactoring user addition to group to graphapi (#7360) * changed user addition to group to graphapi * addressing the review * addressing review regarding nonexistent user * addressing the review * updated expected failures file * changing code to make it pass in reva edge * addressing review * addressing review
… group to graphapi (#7545) * backporting the PR * [tests-only][full-ci] refactoring user addition to group to graphapi (#7360) * changed user addition to group to graphapi * addressing the review * addressing review regarding nonexistent user * addressing the review * updated expected failures file * changing code to make it pass in reva edge * addressing review * addressing review
… group to graphapi (#7545) * backporting the PR * [tests-only][full-ci] refactoring user addition to group to graphapi (#7360) * changed user addition to group to graphapi * addressing the review * addressing review regarding nonexistent user * addressing the review * updated expected failures file * changing code to make it pass in reva edge * addressing review * addressing review
Description
This PR refactors the user addition to group test code from ocs api to graphapi
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: